Fix tests by using API Key for CI #2255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmholt
approved these changes
Oct 25, 2019
src/features/UpdatePowerShell.ts
Outdated
| // Fetch the latest PowerShell releases from GitHub. | ||
| let releaseJson: any; | ||
| if (preview) { | ||
| // This gets all releases and the first one is the latest prerelease if | ||
| // there is a prerelease version. | ||
| releaseJson = (await fetch(PowerShellGitHubPrereleasesUrl) | ||
| releaseJson = (await fetch(PowerShellGitHubPrereleasesUrl, requestConfig) |
There was a problem hiding this comment.
Isn't the point of await to obviate the need for then()?
There was a problem hiding this comment.
It's either this or double awaiting which I felt was a tad less clear with the extra parens and more verbose than an intermediate variable. I can change it if you'd like.
await (await fetch(PowerShellGitHubReleasesUrl, requestConfig)).json();
// or
const res = await fetch(PowerShellGitHubReleasesUrl, requestConfig);
releaseJson = await res.json();There was a problem hiding this comment.
No no, no need to derail the PR
|
@rjmholt refactored for better error handling. I ran CI like 5-8 times and green every time. |
rjmholt
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes the tests by using an API Key for CI so that we aren't rate limited by GitHub's APIs.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready